Threaded Mode | Linear Mode

kreezxil · 19-06-2014, 05:19 PM

Some of us play on multiple packs servers.

As I see it now, you have feature that when I upgrade a server or client, the launcher checks to see if I have a compatible file already existing and if so simply copies it over thus speeding up my download session.

I'd like to see this feature across unrelated packs.

For instance if I have TheMadPack installed which has an insane quanity of mods in it and then go to load From The Darkness which has considerably less, I'd like to see the launcher look at all of the packs I've already downloaded and copy over what is needed that matches the manifest. For instance, I wouldn't have to see the scala compiler download everytime a 22mb file and it is easily present in the other packs.

That would be really helpful.

Thanks for considering.

Kreezxil

***RyanTheAllmighty*** · (This post was last modified: 19-06-2014 05:29 PM by RyanTheAllmighty.)

It already does this. Forge unfortunately provides various different files for scala each with their own hash which is why it's redownloaded between packs sometimes

**dgelessus** · 19-06-2014, 07:40 PM

I'm curious, does the launcher determine identical files by file name, hash or both? Different packs may obviously name their mods differently, and mods with the same name may actually be a different version (e. g. GregTech with ALL MOD VERSIONS being called gregtechmod.zip).

***RyanTheAllmighty*** · 19-06-2014, 08:05 PM

Depends on the pack and how they set things up. The launcher determines if a file needs to be downloaded by checking the file store (downloads folder) for an identical named mod with the same hash. So in the case of gregtech not naming things, if the has doesn't match it will redownload it

kreezxil · 20-06-2014, 11:17 AM

(19-06-2014 08:05 PM)RyanTheAllmighty Wrote: Depends on the pack and how they set things up. The launcher determines if a file needs to be downloaded by checking the file store (downloads folder) for an identical named mod with the same hash. So in the case of gregtech not naming things, if the has doesn't match it will redownload it

So, basically the hash get's messed up because of the filename?

I can think of a solution to that. quit hashing in the filename, start from right after the filename to end of file. Hash that. Then all the scala libraries with the same content regardless of name will hash correctly.

But yeah, I'm glad it works; however, I'd like to point out that when I made my post in the OP that I have witnessed ATLauncher download the scala library, mods and configs all over again if I switch to a NEW PACK that I have not ever tried before despite those mods and libraries existing with the same versions and name in another mod pack.

From my experience with your launcher the behavior only works as intended if I stay within the modpack series. That is, for all my modpacks upgrades both server and client within THE MADPACK your launcher will behave this way, same for the other packs, but when I decide for instance that I want to try a new pack out, one that I have never gotten before, then all the files are downloaded fresh.

I can make a video of the behavior if it will help.

***RyanTheAllmighty*** · 20-06-2014, 11:23 AM

This is intended behavior. The mods may or may not be the same. They don't download again if they already exist. Packs have different versions, different filenames, different hashes etc.

There are a tonne of variables which determine if a file needs to be downloaded or not and I can guarantee it works as intended. If your re downloading mods it's because they need to be as they don't match what the pack is looking for.

Feel free to provide evidence which contradicts this and I'll be more than happy to look into it, but I've just tested a CrackPack install then a UHS install on a clean install, only 1MB of mods was downloads on the UHS install, as is intended.

kreezxil · 21-06-2014, 12:12 AM

(20-06-2014 11:23 AM)RyanTheAllmighty Wrote: This is intended behavior. The mods may or may not be the same. They don't download again if they already exist. Packs have different versions, different filenames, different hashes etc.

There are a tonne of variables which determine if a file needs to be downloaded or not and I can guarantee it works as intended. If your re downloading mods it's because they need to be as they don't match what the pack is looking for.

Feel free to provide evidence which contradicts this and I'll be more than happy to look into it, but I've just tested a CrackPack install then a UHS install on a clean install, only 1MB of mods was downloads on the UHS install, as is intended.

I only brought this up because I had "The Mad Pack", and when I went to install "Skyfactory" that huge scala compiler downloaded again, same file size, same version numbers. and the same for the similar mods between the packs. Then I just did "From the darkness" and got the same result. That huge scala library downloaded again, same size, same version numbers. As far as mods, go, well I expect them to be different because of the rampant development going on with them.

It should be noted that do the server pack first. and then I do my client pack. My client pack is always lickity split.

Perhaps what I'm pointing out is for server packs and not for client packs, client packs might work as you have indicated.

***RyanTheAllmighty*** · 21-06-2014, 02:23 AM

Server packs abide by the same rules. Again doing a crackpack then UHS server install then client required only a couple extra mods for the client side after the server. As I said there are a couple things it uses to determine if it should be downloaded, and it only downloads if it needs to, so if it's downloading p, it has to download it. The exception to this rule is scala